Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix HMR by removing chunks from chunk list hash #7943

Merged
merged 2 commits into from
Apr 11, 2024
Merged

fix HMR by removing chunks from chunk list hash #7943

merged 2 commits into from
Apr 11, 2024

Conversation

sokra
Copy link
Member

@sokra sokra commented Apr 11, 2024 •
edited by padmaia
Loading

Description

Testing Instructions

Closes PACK-2939

@sokra sokra requested a review from a team as a code owner April 11, 2024 16:14
@vercel Vercel
Copy link

vercel bot commented Apr 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview Apr 11, 2024 4:14pm
rust-docs 🔄 Building (Inspect) Visit Preview Apr 11, 2024 4:14pm
8 Ignored Deployments
Name Status Preview Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Apr 11, 2024 4:14pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Apr 11, 2024 4:14pm
examples-gatsby-web ⬜️ Ignored (Inspect) Apr 11, 2024 4:14pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Apr 11, 2024 4:14pm
examples-native-web ⬜️ Ignored (Inspect) Apr 11, 2024 4:14pm
examples-svelte-web ⬜️ Ignored (Inspect) Apr 11, 2024 4:14pm
examples-tailwind-web ⬜️ Ignored (Inspect) Apr 11, 2024 4:14pm
examples-vite-web ⬜️ Ignored (Inspect) Apr 11, 2024 4:14pm

@github-actions GitHub Actions
Copy link
Contributor

⚠️ This change may fail to build next-swc.

Logs 

error: failed to select a version for `swc_core`.
    ... required by package `turbopack-binding v0.1.0 (https://github.com/vercel/turbo?rev=5204e523e1e83f93ae2b3a9cbc8812f083c739a0#9d45eacc)`
    ... which satisfies git dependency `turbopack-binding` (locked to 0.1.0) of package `next-swc-napi v0.0.0 (/root/actions-runner/_work/turbo/turbo/packages/next-swc/crates/napi)`
versions that meet the requirements `^0.90.30` are: 0.90.30

all possible versions conflict with previously selected packages.

  previously selected package `swc_core v0.90.24`
    ... which satisfies dependency `swc_core = "^0.90.24"` (locked to 0.90.24) of package `wasm v0.0.0 (/root/actions-runner/_work/turbo/turbo/packages/next-swc/crates/wasm)`

failed to select a version for `swc_core` which could resolve this conflict

See job summary for details

@github-actions GitHub Actions
Copy link
Contributor

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 11, 2024 •
edited
Loading

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@sokra sokra merged commit b2f90dc into main Apr 11, 2024
44 of 47 checks passed
@sokra sokra deleted the sokra/fix-chunk-list-hash-hmr branch April 11, 2024 16:22
@sokra sokra mentioned this pull request Apr 11, 2024
Merged
sokra added a commit to vercel/next.js that referenced this pull request Apr 11, 2024
@sokra
update turbopack (#64347)
cbee709 
* vercel/turborepo#7409 <!-- hrmny - chore: add
parallel rust frontend and remove unused rust dependencies -->
* vercel/turborepo#7920 <!-- Tobias Koppers - remove
warning when there is no PostCSS config -->
* vercel/turborepo#7856 <!-- Donny/강동윤 - build:
Update `swc_core` to `v0.90.29` -->
* vercel/turborepo#7941 <!-- Tobias Koppers - fix
recursion cycle when having a cycle of dynamic imports -->
* vercel/turborepo#7943 <!-- Tobias Koppers - fix
HMR by removing chunks from chunk list hash -->
@sokra sokra mentioned this pull request Apr 11, 2024
Closed
sokra added a commit that referenced this pull request Apr 11, 2024
@sokra
Revert "fix HMR by removing chunks from chunk list hash (#7943)"
a98a720 
This reverts commit b2f90dc.
@sokra sokra mentioned this pull request Apr 11, 2024
Merged
sokra added a commit that referenced this pull request Apr 11, 2024
@sokra
Revert "fix HMR by removing chunks from chunk list hash" (#7945)
294edf2 
Reverts #7943
@sokra sokra mentioned this pull request Apr 15, 2024
Merged
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@sokra
fix HMR by removing chunks from chunk list hash (vercel/turborepo#7943)
3d069c0 
### Description

<!--
  ✍️ Write a short summary of your work.
  If necessary, include relevant screenshots.
-->

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes PACK-2939
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@sokra
Revert "fix HMR by removing chunks from chunk list hash" (vercel/turb…
833e216 
…orepo#7945)

Reverts vercel/turborepo#7943
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@sokra
fix HMR by removing chunks from chunk list hash (vercel/turborepo#7943)
99822a7 
### Description

<!--
  ✍️ Write a short summary of your work.
  If necessary, include relevant screenshots.
-->

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes PACK-2939
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@sokra
Revert "fix HMR by removing chunks from chunk list hash" (vercel/turb…
52fd625 
…orepo#7945)

Reverts vercel/turborepo#7943
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@sokra
fix HMR by removing chunks from chunk list hash (vercel/turborepo#7943)
6e4143c 
### Description

<!--
  ✍️ Write a short summary of your work.
  If necessary, include relevant screenshots.
-->

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes PACK-2939
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@sokra
Revert "fix HMR by removing chunks from chunk list hash" (vercel/turb…
92eb71c 
…orepo#7945)

Reverts vercel/turborepo#7943
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@sokra
fix HMR by removing chunks from chunk list hash (vercel/turborepo#7943)
e10b164 
### Description

<!--
  ✍️ Write a short summary of your work.
  If necessary, include relevant screenshots.
-->

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes PACK-2939
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@sokra
Revert "fix HMR by removing chunks from chunk list hash" (vercel/turb…
87e3064 
…orepo#7945)

Reverts vercel/turborepo#7943
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timneutkens timneutkens timneutkens approved these changes

Assignees
No one assigned
Labels
created-by: turbopack owned-by: turbopack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sokra @timneutkens